Skip to content

Complete compound workspace asset admission - #128

Merged
flyingrobots merged 2 commits into
mainfrom
perf/compound-workspace-assets
Aug 24, 2026
Merged

Complete compound workspace asset admission#128
flyingrobots merged 2 commits into
mainfrom
perf/compound-workspace-assets

Conversation

@flyingrobots

@flyingrobots flyingrobots commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

  • add bounded scope.assets.putBatch() to compound staging-workspace admission;
  • add optional synchronous retain(value) selection restricted to canonical handles staged by that exact admission;
  • preserve prior workspace roots and v6.5.9 retain-all behavior;
  • reject empty, oversized, malformed, asynchronous, lookalike, and unstaged selections before ref movement;
  • prove one checked publication, closed Git sessions, transitive readback after immediate prune, and later reclamation in SHA-1 and SHA-256 repositories.

Performance evidence

A controlled downstream git-warp prototype reduced cold Git commands from 139 to 50 and incremental commands from 149 to 60. Median wall time fell 52.9% cold and 54.4% incremental with equal semantic fingerprints, cache posture, and replay counts. The 25-command warm read topology did not change. These are explicitly provisional local-prototype results and will be rerun against the public v6.5.10 artifact.

Compatibility

This is additive and migration-free. Stored objects, handles, workspace descriptors, ref namespaces, readers, and existing retain-all calls are unchanged.

Verification

  • pnpm run release:verify: 14/14 stages, 7,186 observed tests;
  • Node units: 2,192 passed, 2 skipped;
  • Bun units: 2,191 passed, 3 skipped;
  • Deno units: 2,182 passed, 12 skipped;
  • Node/Bun/Deno integrations: 207 passed on each runtime;
  • public types, examples, build stamp, npm pack dry-run, and JSR publish dry-run: pass.

The exact-source witness is committed under docs/design/0061-compound-workspace-assets/witness/.

Closes #127

@flyingrobots flyingrobots self-assigned this Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 53 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 22ef4c24-f932-49ab-b87b-68e719651876

📥 Commits

Reviewing files that changed from the base of the PR and between 6d5a43e and 6714750.

📒 Files selected for processing (21)
  • ARCHITECTURE.md
  • BEARING.md
  • CHANGELOG.md
  • GUIDE.md
  • README.md
  • ROADMAP.md
  • STATUS.md
  • docs/design/0061-compound-workspace-assets/compound-workspace-assets.md
  • docs/design/0061-compound-workspace-assets/witness/compound-workspace-assets.json
  • docs/design/0061-compound-workspace-assets/witness/verification.md
  • docs/design/README.md
  • index.d.ts
  • src/domain/services/AssetService.js
  • src/domain/services/StagingWorkspaceRegistry.js
  • src/domain/services/WorkspaceCompoundAdmission.js
  • src/domain/services/WorkspaceCompoundScope.js
  • test/integration/compound-workspace-admission.test.js
  • test/unit/domain/services/AssetService.batch.test.js
  • test/unit/domain/services/StagingWorkspace.compound.test.js
  • test/unit/domain/services/WorkspaceCompoundScope.test.js
  • test/unit/types/declaration-accuracy.test.js
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@flyingrobots
flyingrobots marked this pull request as ready for review August 24, 2026 21:22
@flyingrobots
flyingrobots merged commit 57cd300 into main Aug 24, 2026
6 checks passed
@flyingrobots
flyingrobots deleted the perf/compound-workspace-assets branch August 24, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete compound workspace admission for assets and exact roots

1 participant