Repository navigation
fix: honor boot grace before scale-down identity lookup - #5583
Open
guicaulada wants to merge 1 commit into
Open
guicaulada wants to merge 1 commit into
guicaulada wants to merge 1 commit into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scale-down can emit
UNVERIFIABLE_RUNNERfor a healthy instance that is still registering. On v8.1.0 we observed an instance launch at 19:46:33 UTC, an exact-name lookup miss at 19:46:55, and successful JIT registration at 19:47:04. Identity verification currently runs before the boot-grace check, so an expected startup delay is logged as an error and consumes GitHub requests.Defer identity lookup for runners without a valid GitHub runner ID until the compute provider's boot grace expires. Runners with a valid ID continue through normal evaluation, and an exact-name miss after the grace period still retains the instance conservatively.
Regression coverage exercises registration arriving during the grace period and an unresolved identity after grace expiry, asserting that the early sweep makes no GitHub client/lookup calls and does not mark or terminate the instance.