fix: declare @astrojs/markdown-remark as explicit dependency - #162
Merged
Conversation
Newer @astrojs/starlight and astro releases no longer install @astrojs/markdown-remark transitively, but website/astro.config.mjs uses markdown.remarkPlugins (for the GitHub-admonitions plugin), which requires the unified processor from that package. Declaring it explicitly unblocks astro/starlight dependency bumps that otherwise fail astro check. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI/build breakages caused by newer astro / @astrojs/starlight releases no longer installing @astrojs/markdown-remark transitively, while the site config still relies on the Markdown pipeline that requires it. Declaring @astrojs/markdown-remark as an explicit dependency stabilizes astro check / site builds across dependency updates.
Changes:
- Add
@astrojs/markdown-remarkas an explicit, exactly-pinned dependency inwebsite/package.json. - Update
website/package-lock.jsonto reflect the new direct dependency.
Show a summary per file
| File | Description |
|---|---|
website/package.json |
Adds @astrojs/markdown-remark as a direct dependency (pinned to 7.2.1) so builds don’t depend on transitive installs. |
website/package-lock.json |
Updates the lockfile to include the direct dependency at the workspace root. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Files not reviewed (1)
- website/package-lock.json: Generated file
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot PRs #159 and #160 fail their
Build sitecheck because newer@astrojs/starlightandastroreleases no longer install@astrojs/markdown-remarktransitively, yetwebsite/astro.config.mjsusesmarkdown.remarkPlugins(for the GitHub-admonitions plugin), which requires theunifiedprocessor from that package. This declares it explicitly so any astro/starlight bump can passastro check.Type of change
website/Astro + Starlight wrapper).github/copilot-instructions.md, instructions, agents, skills)Verification
cd website && rm -rf dist && npm run buildsucceeds (218 HTML files built)npm run check:all(the step that was failing in CI,astro check) also passes locally.Screenshots
N/A
Notes for reviewers
Astro pins
@astrojs/markdown-remarkto an exact version per release, so a caret range cannot be used. This fix pins7.2.1to match the current baseastro@7.0.9, which is a no-op for the resolved tree today (it was already present transitively) but keeps it installed once starlight/astro drop the transitive dependency.Coupling to be aware of when rebasing the Dependabot PRs:
markdown-remark@7.2.1and will pass once rebased onto this fix.markdown-remark@7.2.2, so that PR will additionally needmarkdown-remarkbumped to7.2.2to resolve. Now that it is a direct dependency, Dependabot should carry it along in future updates.