Skip to content

C++: Accept test changes after github/codeql#23046 #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MathiasVP wants to merge 2 commits into
base: next
Choose a base branch
from
Open

C++: Accept test changes after github/codeql#23046 #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a32f4a5
C++: Accept test changes after github/codeql#23046.
MathiasVP Nov 8, 2026
887cc8d
C++: Select the indirect node for the sink in 'cpp/autosar/invalid-fu…
MathiasVP Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/autosar/src/rules/A7-5-1/InvalidFunctionReturnType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ where
p.getUnderlyingType().isDeeplyConst() and
p.getType() instanceof DerivedType and
p.getFunction().getType().stripTopLevelSpecifiers() instanceof DerivedType and
DataFlow::localFlow(DataFlow::parameterNode(p), DataFlow::exprNode(ret.getExpr()))
// `parameterNode` on a reference parameter gives back the node representing the indirection of the
// reference, so we pick the indirect node for the return expression.
DataFlow::localFlow(DataFlow::parameterNode(p), DataFlow::indirectExprNode(ret.getExpr()))
select ret,
"Function " + p.getFunction().getName() +
" returns a reference or a pointer to $@ that is passed by reference to const.", p, "parameter"
2 changes: 2 additions & 0 deletions ...aluestoredinunrelatedsmartpointer/OwnedPointerValueStoredInUnrelatedSmartPointer.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ edges
| test.cpp:5:24:5:25 | call to shared_ptr | test.cpp:6:28:6:29 | p1 | provenance | |
| test.cpp:5:27:5:28 | v1 | test.cpp:5:24:5:25 | call to shared_ptr | provenance | Config |
| test.cpp:5:27:5:28 | v1 | test.cpp:5:24:5:25 | call to shared_ptr | provenance | Config |
| test.cpp:5:27:5:28 | v1 | test.cpp:5:24:5:25 | call to shared_ptr | provenance | TaintFunction |
| test.cpp:5:27:5:28 | v1 | test.cpp:5:24:5:25 | call to shared_ptr | provenance | TaintFunction |
Comment thread
MathiasVP marked this conversation as resolved.
Resolved
| test.cpp:6:28:6:29 | p1 | test.cpp:6:31:6:33 | call to get | provenance | Config |
| test.cpp:6:28:6:29 | p1 | test.cpp:6:31:6:33 | call to get | provenance | Config |
| test.cpp:8:3:8:14 | ... = ... | test.cpp:9:28:9:29 | v2 | provenance | |
Expand Down
Loading