C++: Support access paths for sources and sinks - #22374
Draft
MathiasVP wants to merge 7 commits into
Draft
Conversation
…nks (no test changes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #22145 has been merged we can finally add MaD support for access paths at sources and sinks.
Commit-by-commit review recommended.
ParameterNodes andArgumentNodes in dataflow which will make the main commit simpler.There's a small change to the
toStringon sources (and sinks) defined in MaD. Previously, it would be thetoStringof the underlying dataflow node. However, due to the way MaD works it's hard (impossible?) to keep this behavior. Thanks to Tom's PR the location of the source and sink elements remain identical, though, so we're not risking any alert fluctuations. It does mean that the number of indirections isn't visible on the source node and sink node, which is a bit of a shame. I don't think that's enough to block this PR, though.