Repository navigation
Unified: Preserve generic arguments on qualified Swift types - #22817
Merged
Merged
Conversation
Record the current extraction of generic arguments on qualified and nested types before fixing their omission. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0033cd3-ca30-4469-969f-36c4cf463e71
Wrap generic member types in generic_type_expr so qualified and nested type arguments remain visible to name binding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0033cd3-ca30-4469-969f-36c4cf463e71
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The translation rule handles both terminal and nested generic qualification, with matching corpus coverage.
0 open findings
What changed in this PR
Preserves generic arguments when translating qualified Swift types, preventing unused-variable false positives.
Changes:
- Adds generic handling for
memberType. - Adds corpus coverage for nested qualified generic types.
| File | Description |
|---|---|
unified/extractor/src/languages/swift/swift.rs |
Translates qualified generic types without dropping arguments. |
unified/extractor/tests/corpus/swift/types/qualified-type.swift |
Adds regression inputs. |
unified/extractor/tests/corpus/swift/types/qualified-type.output |
Records generated AST expectations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve generic arguments on qualified Swift types, that is, things such as
Outer.Inner<Type>.