Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Default behavior to preserve unless a training scenario says otherwise:
- Favorite count includes unread favorites.
- Empty-state copy should mention changing the search term, genre, or reading status.

Use the current Node.js LTS. The app declares `engines.node` as `^20.19.0 || >=22.12.0`. CI uses Node 22.
Use the current Node.js LTS. The app declares `engines.node` as `>=24.0.0`. CI uses Node 24.

## Validation

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/book-app-web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: "22"
node-version: "24"
cache: npm
cache-dependency-path: samples/book-app-web/package-lock.json

Expand Down
2 changes: 1 addition & 1 deletion appendices/training-github-scenarios.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ This matches the script's conversation comment. Do not create an inline review t

## Manual fallback: Create a failing check example

The repository includes the [Book app web workflow](../.github/workflows/book-app-web.yml). It uses Node.js 22, installs dependencies with `npm ci`, runs `npm test -- --run`, and builds `samples/book-app-web` with `npm run build`.
The repository includes the [Book app web workflow](../.github/workflows/book-app-web.yml). It uses Node.js 24, installs dependencies with `npm ci`, runs `npm test -- --run`, and builds `samples/book-app-web` with `npm run build`.

The **Failing stats check practice** PR created above is the failing-check example. Do not create a second branch or PR for it.

Expand Down
2 changes: 1 addition & 1 deletion samples/book-app-web/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion samples/book-app-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"type": "module",
"engines": {
"node": "^20.19.0 || >=22.12.0"
"node": ">=24.0.0"
},
"scripts": {
"dev": "vite",
Expand Down
Loading