Skip to content

pass in all configured experiments - #1761

Draft
jakecoffman wants to merge 2 commits into
mainfrom
jakecoffman/proxy-read-only-git-credentials-flag
Draft

pass in all configured experiments#1761
jakecoffman wants to merge 2 commits into
mainfrom
jakecoffman/proxy-read-only-git-credentials-flag

Conversation

@jakecoffman

@jakecoffman jakecoffman commented Aug 21, 2026

Copy link
Copy Markdown
Member

Works with:

This makes it easier to use experiments in the Proxy. We add the experiments from the job to the JSON file we give to the Proxy as input. It doesn't require an additional PR to add the experiment as an environment variable.

Also this graduates the Proxy caching experiment to always be on. It has been enabled since January 2024.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Forwards job experiments to the proxy configuration and permanently enables proxy caching.

Changes:

  • Passes all job experiments into config.json.
  • Enables proxy caching unconditionally.
  • Updates tests and bundled output.
Show a summary per file
File Description
src/updater.ts Passes experiments to ProxyBuilder.
src/proxy.ts Adds experiments to config and enables caching.
src/config-types.ts Extends the proxy config type.
dist/main.js Updates bundled runtime code.
__tests__/updater.test.ts Tests experiment forwarding.
__tests__/proxy.test.ts Tests config forwarding and caching.
__tests__/proxy-integration.test.ts Adapts builder construction.
__tests__/updater-builder-integration.test.ts Adapts integration setup.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Suppressed comments (2)

tests/updater-builder-integration.test.ts:85

  • ProxyBuilder.run expects jobToken before dependabotApiUrl, but these values are reversed. This starts the integration proxy with the URL as JOB_TOKEN and xxxyyyzzzz as DEPENDABOT_API_URL; swap them so the test exercises a valid proxy configuration.
      dependabotApiUrl,
      jobToken,

tests/updater-builder-integration.test.ts:122

  • ProxyBuilder.run expects jobToken before dependabotApiUrl, but these values are reversed. This starts the integration proxy with the URL as JOB_TOKEN and xxxyyyzzzz as DEPENDABOT_API_URL; swap them so the test exercises a valid proxy configuration.
      dependabotApiUrl,
      jobToken,
  • Files reviewed: 7/8 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread __tests__/updater-builder-integration.test.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants