pass in all configured experiments - #1761
Draft
jakecoffman wants to merge 2 commits into
Draft
Conversation
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Forwards job experiments to the proxy configuration and permanently enables proxy caching.
Changes:
- Passes all job experiments into
config.json. - Enables proxy caching unconditionally.
- Updates tests and bundled output.
Show a summary per file
| File | Description |
|---|---|
src/updater.ts |
Passes experiments to ProxyBuilder. |
src/proxy.ts |
Adds experiments to config and enables caching. |
src/config-types.ts |
Extends the proxy config type. |
dist/main.js |
Updates bundled runtime code. |
__tests__/updater.test.ts |
Tests experiment forwarding. |
__tests__/proxy.test.ts |
Tests config forwarding and caching. |
__tests__/proxy-integration.test.ts |
Adapts builder construction. |
__tests__/updater-builder-integration.test.ts |
Adapts integration setup. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (2)
tests/updater-builder-integration.test.ts:85
ProxyBuilder.runexpectsjobTokenbeforedependabotApiUrl, but these values are reversed. This starts the integration proxy with the URL asJOB_TOKENandxxxyyyzzzzasDEPENDABOT_API_URL; swap them so the test exercises a valid proxy configuration.
dependabotApiUrl,
jobToken,
tests/updater-builder-integration.test.ts:122
ProxyBuilder.runexpectsjobTokenbeforedependabotApiUrl, but these values are reversed. This starts the integration proxy with the URL asJOB_TOKENandxxxyyyzzzzasDEPENDABOT_API_URL; swap them so the test exercises a valid proxy configuration.
dependabotApiUrl,
jobToken,
- Files reviewed: 7/8 changed files
- Comments generated: 1
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works with:
This makes it easier to use experiments in the Proxy. We add the experiments from the job to the JSON file we give to the Proxy as input. It doesn't require an additional PR to add the experiment as an environment variable.
Also this graduates the Proxy caching experiment to always be on. It has been enabled since January 2024.