Fix package-level mutable slice/map reassignment in virtual_fs.go and actionpins/data.go

[Copilot]

LintMonster flagged 5 findings where package-level slice/map variables were mutated via wholesale reassignment, risking shared-state leakage and data races: builtinVirtualFiles in pkg/parser/virtual_fs.go, and cachedActionPins, cachedActionPinsByRepo, cachedContainerPins in pkg/actionpins/data.go.

pkg/parser/virtual_fs.go

• builtinVirtualFiles changed from map[string][]byte to *map[string][]byte. Registration still builds a fresh copy-on-write snapshot, but now swaps the pointer instead of reassigning the map itself, so the package-level variable is never mutated in place.
• Read sites (BuiltinVirtualFileExists, readFileFunc, wasm build) dereference the pointer; existing sync.RWMutex guarding is unchanged.

pkg/actionpins/data.go

• Introduced an actionPinsCache struct bundling pins, byRepo, and containers.
• Replaced the three separate package-level slice/map vars with a single *actionPinsCache pointer (cachedPins), populated exactly once inside the existing sync.Once.
• getActionPins(), GetActionPinsByRepo(), and GetContainerPin() now read through a getCachedActionPins() accessor instead of touching separate globals.

type actionPinsCache struct {
	pins       []ActionPin
	byRepo     map[string][]ActionPin
	containers map[string]ContainerPin
}

var (
	cachedPins     *actionPinsCache
	actionPinsOnce sync.Once
)

Public APIs and behavior are unchanged — this is purely an internal storage-representation change to eliminate the reassignment pattern the linter flags.

• Fixes [lint-monster] LintMonster: package-level mutable state cleanup #53889

[github-actions]

Hey @github/gh-aw-team 👋 — thanks for working on the package-level mutable state cleanup! This PR is a solid fix for the LintMonster findings in #53889.

The refactoring is well-focused:

• virtual_fs.go: Converts builtinVirtualFiles to a pointer type to eliminate in-place mutations
• actionpins/data.go: Bundles three related package-level variables into a single actionPinsCache struct, eliminating reassignment patterns
• Test coverage is updated to match the new internal structure

The changes preserve public APIs and behavior while eliminating the data-race hazards flagged by the linter. This looks ready for review!

Generated by ✅ Contribution Check · auto · 57.7 AIC · ⌖ 4.11 AIC · ⊞ 9.2K · ◷

[github-actions]

Triage: category=bug · risk=low · score=44/100 (impact 18/50, urgency 10/30, quality 16/20)
Recommended action: batch_review

Small, contained bug fix (4 files, 46+/30-) with lgtm label. Undraft to trigger CI, then group with similar low-risk fixes for review.

Generated by 🔧 PR Triage Agent · auto · 58.8 AIC · ⌖ 2.56 AIC · ⊞ 8.3K · ◷