Skip to content

Match markup file extensions without regard to case #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hashim1999164 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Match markup file extensions without regard to case #2098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/github/markup/implementation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ def match?(filename, language)
private

def file_ext_regexp
@file_ext_regexp ||= /\.(#{regexp})\z/
# Use regexp.source so an /i flag on this pattern applies to the
# extension itself. Interpolating a Regexp object embeds (?-mix:),
# which would keep .MD from matching /md/.
@file_ext_regexp ||= /\.(?:#{regexp.source})\z/i
end
end
end
Expand Down
2 changes: 2 additions & 0 deletions test/coverage_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ def initialize; super(/md|markdown/, []); end
assert impl.match?("README.md", nil)
# call again to cover the memoization branch in file_ext_regexp
assert impl.match?("README.markdown", nil)
assert impl.match?("README.MD", nil)
assert impl.match?("README.Markdown", nil)
refute impl.match?("README.txt", nil)
end
end
Expand Down