Fix catalog-latest-url-bypass: require tag-pinned catalog download URLs - #4194
Open
Shaurya2k06 wants to merge 2 commits into
Open
Fix catalog-latest-url-bypass: require tag-pinned catalog download URLs#4194Shaurya2k06 wants to merge 2 commits into
Shaurya2k06 wants to merge 2 commits into
Conversation
Reject floating releases/latest URLs in the community catalog agent workflows and require the URL tag to match the submitted version. Refs github#4185 Assisted-by: Cursor Grok 4.6 (supervised) Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
mnriem
requested changes
Aug 19, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
Separate substring checks for vX.Y.Z and X.Y.Z were not independent. Refs github#4185 Assisted-by: Cursor Grok 4.6 (supervised) Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix — catalog-latest-url-bypass
Proposed fix for issue #4185, applying the remediation from the bug assessment.
Verdict: valid · Severity: high
Summary
Community catalog agent workflows treated tag-pinned
download_urlas advisory and accepted floatingreleases/latest/aliases after an HTTP 200 check. The three workflows now MUST use a tag-pinned URL, rejectreleases/latest/before any HTTP check, and require the URL tag to match the submitted version (vX.Y.ZorX.Y.Z).Changes
.github/workflows/add-community-extension.mdreleases/latest/reject + tag/version match.github/workflows/add-community-preset.md.github/workflows/add-community-bundle.mdtests/test_github_workflows.pyTests Added or Updated
tests/test_github_workflows.py::test_community_submission_workflows_require_tag_pinned_download_urls— asserts each community workflow drops “should follow the pattern”, forbidsreleases/latest/, and requires tag/version match languageLocal Verification
.venv/bin/python -m pytest tests/test_github_workflows.py -q→ 6 passed.venv/bin/specify --help→ CLI help renderedgh aw compilewas not available locally; lock YAML left unchanged because compiled workflows runtime-import the.mdprompt bodiesDeviations from Assessment
None. Scope is the three workflow files plus a static test, as preferred. No shared checklist doc, no Python URL validator, no skill/template changes.
Risks & Review Notes
Refs #4185
Testing
uv run specify --helpuv sync && uv run pytest(focused:tests/test_github_workflows.py)AI Disclosure
Drafted and implemented under human supervision by Cursor Grok 4.6. I reviewed the code, ran tests, and the commit myself. I take full responsibility of the code generated by me.