[github-actions]

Bug fix — oversized-number-crash

Proposed fix for issue #5194, applying the
remediation from the bug assessment.

Verdict: valid · Severity: low

Summary

The Python extension branch-creation script now validates --number against a bounded integer domain before conversion, so oversized numeric inputs fail with a clear argument error instead of crashing at int().

Changes

File	Change	Notes
extensions/git/scripts/python/create_new_feature_branch.py	modified	Added int64-style bound validation (0..2**63-1) for --number and a defensive conversion guard with user-facing error text.
tests/extensions/git/test_git_extension_python_parity.py	modified	Added boundary and regression tests for max, max+1, and oversized digit-only --number inputs; asserts no traceback on rejection.

Tests Added or Updated

• tests/extensions/git/test_git_extension_python_parity.py::TestCreateFeatureBranchParity::test_explicit_number_max_int64_accepted — verifies the maximum supported explicit number is accepted.
• tests/extensions/git/test_git_extension_python_parity.py::TestCreateFeatureBranchParity::test_explicit_number_above_max_int64_rejected — pins rejection for max+1 with expected error message.
• tests/extensions/git/test_git_extension_python_parity.py::TestCreateFeatureBranchParity::test_explicit_number_oversized_digits_rejected_without_traceback — verifies long digit strings are rejected cleanly without traceback.

Local Verification

• Commands run: python3 extensions/git/scripts/python/create_new_feature_branch.py --json --dry-run --number 42 "some feature" → pass (exit 0)
• Commands run: python3 extensions/git/scripts/python/create_new_feature_branch.py --json --dry-run --number 9223372036854775808 "some feature" → expected validation failure (exit 1, bounded-range error)
• Commands run: python3 extensions/git/scripts/python/create_new_feature_branch.py --json --dry-run --number <5000-digit number> "some feature" → expected validation failure (exit 1, bounded-range error, no traceback)
• python3 -m pytest ... could not run in this runner because pytest is unavailable in the base Python environment.

Deviations from Assessment

• Added Python-only parity tests that explicitly codify current divergence from bash for oversized --number handling, rather than changing bash/powershell behavior in this fix-stage patch.

Risks & Review Notes

• Bash/PowerShell extension twins currently do not enforce the same explicit upper bound for --number; this PR intentionally scopes remediation to the Python crash path identified in the assessment.

Refs #5194 · cc @soarkit

• Fixes The Python branch-creation port accepts an oversized --number and crashes at int() instead of rejecting it #5194

Generated by 🛠️ Fix Bug from Labeled Issue for #5194 · copilot · gpt53codex · 49.1 AIC · ⌖ 0.695 AIC · ⊞ 25.1K · ◷

[Copilot]

🟡 Changes recommended

The missing Git extension and catalog version bumps prevent existing installations from receiving the fix, while discarded normalization causes valid, heavily zero-padded branch numbers to be rejected.

2 open issues

• Bump the Git extension version in the manifest and catalog · New
• Preserve the validated branch number to avoid digit-limit rejection · New

What changed in this PR

This PR addresses #5194 by bounding explicit --number values in the Git extension’s Python branch-creation script, replacing oversized-input tracebacks with argument errors.

Changes:

• Validates explicit numbers against 0..2**63-1 before conversion.
• Adds defensive handling for conversion failures.
• Adds Python-only tests for the maximum, maximum plus one, and 5,000-digit inputs; Bash and PowerShell behavior remains unchanged.

File	Description
tests/​extensions/​git/​test_git_extension_python_parity.py	Adds boundary and oversized-input regression tests.
extensions/​git/​scripts/​python/​create_new_feature_branch.py	Adds bounded number validation and conversion-error handling.

_{Review effort: Balanced (auto)}

[Copilot]

🟢 Approval recommended

The crash path for oversized explicit feature numbers is addressed through bounded non-negative int64 parsing, defensive conversion handling, and targeted regression coverage.

1 open issue

• Bump the Git extension version in the manifest and catalog

1 resolved since last review

• Preserve the validated branch number to avoid digit-limit rejection

_{Review effort: Lite (auto)}

[Copilot]

🟡 Changes recommended

An active moderate-severity issue remains because automatic number detection can produce an out-of-domain feature-branch number without rejecting it.

2 open issues

• Bump the Git extension version in the manifest and catalog
• Auto-detected feature numbers can exceed the configured maximum · New

_{Review effort: Lite (auto)}

[mnriem]

@copilot resolve the merge conflicts in this pull request

[Copilot]

🔵 Needs a closer look

Human assessment is needed because the change introduces a critical bundled-extension test failure and an unhandled extreme-input path that can still produce a traceback.

1 open issue

• Bump the Git extension version in the manifest and catalog

1 resolved since last review

• Auto-detected feature numbers can exceed the configured maximum

_{Review effort: Lite (auto)}

[Copilot]

@copilot resolve the merge conflicts in this pull request

Merged main and resolved the Git extension version conflicts, retaining version 1.0.3 and updating its manifest test. The focused Git extension suites pass (188 tests). Merge commit: 83d4de1.

[Copilot]

🟢 Approval recommended

No active review issues remain for the numeric-input validation changes, although regression tests were not executed during this review.

1 open issue

• Bump the Git extension version in the manifest and catalog

_{Review effort: Balanced (auto)}

[Copilot]

🟢 Approval recommended

No active review issues are recorded for the feature-number bounds fix, although tests and regression comparisons were not executed during review.

1 open issue

• Bump the Git extension version in the manifest and catalog

_{Review effort: Balanced (auto)}

[Copilot]

🟢 Approval recommended

No active review issues were reported for the feature-number validation change, although tests were not run during the review.

No open issues 🎉

1 resolved since last review

• Bump the Git extension version in the manifest and catalog

_{Review effort: Balanced (auto)}