Repository navigation
Preserve explicitly configured zero typing delays - #30
Merged
liuliu-dev merged 2 commits intoOct 20, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Whitespace-only delay attributes now disable delays instead of retaining the 40 ms default.
1 open issue
What changed in this PR
Allows callers to disable character and line delays explicitly in the typing-effect element.
Changes:
- Preserves numeric zero in both delay getters.
- Adds regression coverage for attributes, property assignments, and empty-attribute defaults.
| File | Description |
|---|---|
| test/test.js | Tests zero delays and empty-attribute fallback. |
| src/index.ts | Preserves zero before applying the existing fallback. |
Review effort: Max
liuliu-dev
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Setting
characterDelayorlineDelayto zero still returns the default 40 ms, so callers cannot turn off the corresponding delay. Both setters already accept zero, and the typing implementation already supports it.Preserve numeric zero before applying the existing fallback. Missing, empty or whitespace-only attributes keep their default, and reduced-motion handling is unchanged. The regression covers delay attributes, property assignments, and empty/whitespace/fractional fallbacks.
Validation: the regression first returned 40 instead of zero; all 9 Chromium tests now pass through the repository's Karma runner. The TypeScript distribution build and full ESLint check pass with the installed lockfile dependencies on Node 24. The Windows cleanup wrapper was bypassed by running the same tools directly; Firefox and WebKit were not run.