Skip to content

fix(ui): drop menu items that never work and show the live channel's Delete hint - #678

Merged
iamnbutler merged 1 commit into
mainfrom
fix-dead-menus
Oct 23, 2026
Merged

iamnbutler merged 1 commit into
mainfrom
fix-dead-menus

Conversation

@iamnbutler

Copy link
Copy Markdown
Contributor

Map ids ^23, ^2, ^713, ^559, ^421 (dead menu items).

  • ^23 Sign out and ^2 Download app: already removed from the account menu in fix(app): remove the account menu's Sign out and Download app items #572; nothing left to do.
  • ^713: the UI kit's Manually create PR item and its onManualCreatePr prop are removed. The app never passed it, so it never showed; Create PR's menu keeps Create draft PR.
  • ^559: a message's More menu only offers Delete when the message can be deleted. A deleted message, or one in an archived channel, no longer gets an enabled More whose only item is a disabled Delete; on desktop the More button is hidden when it would hold nothing.
  • ^421: a live channel's row menu now passes onDelete, so it shows the existing disabled Delete channel — Archive first hint, pointing at the path to deletion. Archived channels are unchanged.

Smoke: isolated host from this lane (ace serve --loopback --port 5110, own ACE_HOME, config and keychain service), headless Chromium against the built app. A live channel's right-click menu showed Archive channel and a disabled Delete channel Archive first. My message's More showed Edit and Delete; after Delete message, hovering Message deleted showed no More button. bun types and bun run ci pass.

Built in Ace

No. Built by Claude Code as a fix-train worker for the ace-map review, because the train runs outside an Ace channel; the smoke drove the web app with headless Playwright. Dogfooding gap tracked in #5.

@iamnbutler
iamnbutler merged commit 9922b75 into main Oct 23, 2026
1 check passed
@iamnbutler
iamnbutler deleted the fix-dead-menus branch October 23, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant