Repository navigation
fix(host): leave the directory on its server, so the serving Mac sees a teammate leave and rejoin - #692
Merged
Conversation
… a teammate leave and rejoin Why: apps/host/src/directory.ts#function configure | leaving or changing directories DELETEs this host from the old one, after any publish under way to it, or the serving Mac keeps the stale row and a rejoin never counts as a join Why: apps/host/src/directory-server.ts#function handle | a host leaves only as its whois machine name, and leaving calls members so the serving host re-reads its own directory now
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host that leaves or changes its directory now removes itself from the old one (
DELETE /hosts/<name>, after any publish already under way to it). The directory a Mac serves calls back on that leave as well as on a first publish, so the serving Mac re-reads it right away. Before this, a host that left kept its row, so its rejoin didn't count as a first publish, and the serving Mac's Settings → Team never showed it leave or come back. services/directory gets the sameDELETEand will have it once it's redeployed. Until then a leave there just logsdirectory.leave.failed.Settings → Team also hides
Left the directory./Directory checked and joined.once the host's join state changes somewhere else, such as anace directory <url>rejoin.Map: ^901, ^115. Refs #686, #636.
Smoke test (two
bun ace servehosts from this lane on one Mac, isolated homes, ports 5160 and 5162, A serving):directory.left, and A's open Settings → Team re-synced straight away (11:00:59 → 11:01:37) instead of waiting for its heartbeat.ace directory <url>. B's open Settings → Team droppedLeft the directory.and shows the joined, synced row.natembp, so the directory sees them as one row, and testing that needs a second Mac.Built in Ace
No. Claude Code (a fix-train worker) wrote this from the shell and a headless Playwright browser, not in an Ace channel (#5).