Repository navigation
test(engine): wait for the failed attempt's teardown instead of sleeping - #32
Merged
Merged
Conversation
…ing (#31 review note)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-blocking P3 from the PR #31 round-2 review (run local-review-review-router-18e8f63bd99c0b30-1).
TestCancelReachesARetryStartedDuringTeardownslept 100 ms and assumed attempt 1's teardown had happened by then. Under slow scheduling, the cancel could land first and the test would pass without exercising the bug.The test now waits until the agent slot count drops from 2 to 1. That happens under
e.muin the same block as the guarded in-flight delete, so teardown has finished when the cancel is sent.Test only. Results: 10/10 green on main; 5/5 red against the pre-fix unconditional delete.