Skip to content

test(engine): wait for the failed attempt's teardown instead of sleeping - #32

Merged
jerryfane merged 1 commit into
mainfrom
test/retry-teardown-sync
Nov 17, 2026
Merged

jerryfane merged 1 commit into
mainfrom
test/retry-teardown-sync

Conversation

@jerryfane

Copy link
Copy Markdown
Contributor

Non-blocking P3 from the PR #31 round-2 review (run local-review-review-router-18e8f63bd99c0b30-1). TestCancelReachesARetryStartedDuringTeardown slept 100 ms and assumed attempt 1's teardown had happened by then. Under slow scheduling, the cancel could land first and the test would pass without exercising the bug.

The test now waits until the agent slot count drops from 2 to 1. That happens under e.mu in the same block as the guarded in-flight delete, so teardown has finished when the cancel is sent.

Test only. Results: 10/10 green on main; 5/5 red against the pre-fix unconditional delete.

@jerryfane
jerryfane merged commit 5f9cac0 into main Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant