Skip to content

fix(java): reject unparseable dates with the legacy date-time provider #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EloB wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(java): reject unparseable dates with the legacy date-time provider #3554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2fb8b
test(java): run optional-date-time.schema with the legacy date-time p…
EloB Nov 15, 2026
2899bb3
fix(java): reject unparseable dates with the legacy date-time provider
EloB Nov 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/quicktype-core/src/language/Java/DateTimeProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@ export class JavaLegacyDateTimeProvider extends JavaDateTimeProvider {
});
},
);
this._renderer.emitLine("return null;");
this._renderer.emitLine(
'throw new IllegalArgumentException("Unparseable date: " + str);',
);
},
);

Expand Down
12 changes: 9 additions & 3 deletions test/languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,15 @@ export const JavaLanguage: Language = {
skipMiscJSON: false,
skipSchema: ["optional-property.schema"],
rendererOptions: {},
// The default is array-type=list; this keeps the T[] code path
// covered.
quickTestRendererOptions: [{ "array-type": "array" }],
quickTestRendererOptions: [
// The default is array-type=list; this keeps the T[] code path
// covered.
{ "array-type": "array" },
// CI runs schema-java, not schema-java-datetime-legacy: this runs
// the legacy provider's date and time parsing, including the
// expected-failure sample.
["optional-date-time.schema", { "datetime-provider": "legacy" }],
],
sourceFiles: ["src/language/Java/index.ts"],
};

Expand Down