Skip to content

fix(cjson): fix crashes and undefined behavior in generated code #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EloB wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(cjson): fix crashes and undefined behavior in generated code #3557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9f8c56
test: cover top-level maps of integers and top-level arrays of null
EloB Nov 15, 2026
5902704
fix(cjson): fix crashes and undefined behavior in generated code
EloB Nov 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
376 changes: 143 additions & 233 deletions packages/quicktype-core/src/language/CJSON/CJSONRenderer.ts
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions test/inputs/schema/top-level-integer-map.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{ "a": 1, "b": -2 }
6 changes: 6 additions & 0 deletions test/inputs/schema/top-level-integer-map.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "object",
"additionalProperties": {
"type": "integer"
}
}
1 change: 1 addition & 0 deletions test/inputs/schema/top-level-null-array.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[null, null]
6 changes: 6 additions & 0 deletions test/inputs/schema/top-level-null-array.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "array",
"items": {
"type": "null"
}
}
8 changes: 7 additions & 1 deletion test/languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,12 @@ export const ObjectiveCLanguage: Language = {
"blns-object.json",
],
skipMiscJSON: false,
skipSchema: ["optional-property.schema"],
skipSchema: [
"optional-property.schema",
// A top-level array of null checks its items with `id.class`, which
// does not compile.
"top-level-null-array.schema",
],
rendererOptions: { functions: "true" },
quickTestRendererOptions: [],
sourceFiles: ["src/language/Objective-C/index.ts"],
Expand Down Expand Up @@ -1722,6 +1727,7 @@ export const PHPLanguage: Language = {
"recursive-union-flattening.schema",
// The driver does not support top-level arrays.
"issue2680-top-level-array.schema",
"top-level-null-array.schema",
],
rendererOptions: {},
quickTestRendererOptions: [],
Expand Down