fix: don't duplicate issue cross-references on edit - #38881
Draft
silverwind wants to merge 1 commit into
Draft
Conversation
Editing a mention added a second timeline entry on the referenced issue, because the lookup skipped neutered rows and the match compared the reference action. Removing and re-adding a mention, or changing "closes #1" to a plain "#1", left the old row behind and inserted a new one. Match on the target issue alone and write the new action to the row that already exists, so one entry survives every edit, as on GitHub. Assisted-by: Claude Code:claude-opus-5
GiteaBot
added
the
lgtm/need 2
Member
Author
|
Maybe it's better to go for per-issue dedup. Initial investigation shows that it may require a migration, that's why I put it off. |
silverwind
marked this pull request as draft
August 12, 2026 08:56
silverwind
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't duplicate issue cross-references when editing a comment. It dedupes per-comment, GitHub dedupes per-issue which would be a much bigger rewrite that I will leave for later.