Skip to content

docs: remove duplicated word in infile comment - #1855

Merged
shogo82148 merged 1 commit into
go-sql-driver:masterfrom
ninglinLiu:docs/fix-an-an-typo
Nov 15, 2026
Merged

shogo82148 merged 1 commit into
go-sql-driver:masterfrom
ninglinLiu:docs/fix-an-an-typo

Conversation

@ninglinLiu

Copy link
Copy Markdown
Contributor

Description

Remove a duplicated "an" in the infile comment ("return an an absolute path" -> "return an absolute path"). Comment only; no behavior change.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The comment in handleInFileRequest was corrected to remove a duplicated word. No code behavior changed.

Changes

Comment wording

Layer / File(s) Summary
Correct comment wording
infile.go
The comment now says “an absolute path.” Code behavior is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: julienschmidt

Merge Risk: Minimal · up to 1f10f

This is a comment-only typo fix with no behavior change, so there is no merge risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: removing a duplicated word in the infile comment. The changeset is a one-line comment fix in infile.go that changes "an an" to "an". The title is specific and matches the m…
Description check Passed The description states the change: it removes a duplicated "an" in the infile comment and notes that no behavior changes. This matches the single-line comment edit in infile.go. The checklist items re…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: removing a duplicated word in the infile comment. The changeset is a one-line comment fix in infile.go that changes "an an" to "an". The title is specific and matches the main change. It uses the docs: prefix, which fits a comment-only edit.

Full details: Description check

Explanation

The description states the change: it removes a duplicated "an" in the infile comment and notes that no behavior changes. This matches the single-line comment edit in infile.go. The checklist items relate to the change, although the tests are unchecked.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f203fc6-1d38-4792-b956-91fd56f24cba
Commits

Reviewing files that changed from the base of the PR and between 4b7cc9c and 1f10fb5.

Files selected for processing: 1

  • infile.go

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 86.643% (-0.04%) from 86.685% — ninglinLiu:docs/fix-an-an-typo into go-sql-driver:master

@shogo82148 shogo82148 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148
shogo82148 merged commit f32af30 into go-sql-driver:master Nov 15, 2026
28 checks passed
morgo added a commit to block/mysql that referenced this pull request Nov 16, 2026
Brings in:
- conncheck: preserve and report idle server errors (go-sql-driver#1843)
- Set tinyInt1IsBool to false by default (go-sql-driver#1845)
- rows: decode short values inline and share empty values (go-sql-driver#1846)
- docs: remove duplicated word in infile comment (go-sql-driver#1855)

No textual conflicts. Two fork adaptations in the new conncheck code:
- conncheck_error_test.go imports internal/compression from the fork's
  module path (github.com/block/mysql).
- TestIdleErrorRejectReadOnly no longer sets Config.RejectReadOnly, which
  the fork removed (read-only rejection is unconditional). The test still
  checks the same thing: idleError returns the original server error rather
  than applying read-only rejection. The matching comment in
  conncheck_error.go now says "read-only rejection".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants