Repository navigation
Conversation
Author
|
Just noticed that the sha256 object format was experimentally supported in Git 2.29 and marked as stable in 2.51. Should I give a friendlier error message? Or is it too early to add sha256 support? |
Member
no we can just claim v2 requires Git 2.51, no issue. |
4 tasks done
unknwon
added a commit
to gogs/gogs
that referenced
this pull request
Nov 12, 2026
Object IDs in internal/git are now an Oid, either a *SHA1 or a *SHA256, following gogs/git-module#140. Tree listings are parsed without assuming the length of an ID, and the empty ID of a reference update is recognized in either object format. Repositories can be created with a chosen object format from the web form and the API. Routes, references and links accept 64-character commit IDs, and a migration widens the database columns that store commit IDs to 64 characters. Co-authored-by: Linsen Zhou <i@lin.moe>
unknwon
added a commit
to gogs/gogs
that referenced
this pull request
Nov 12, 2026
Object IDs in internal/git are now an Oid, either a *SHA1 or a *SHA256, following gogs/git-module#140. Tree listings are parsed without assuming the length of an ID, and the empty ID of a reference update is recognized in either object format. Repositories can be created with a chosen object format from the web form and the API. Routes, references and links accept 64-character commit IDs, and a migration widens the database columns that store commit IDs to 64 characters. Co-authored-by: Linsen Zhou <i@lin.moe>
unknwon
added a commit
to gogs/gogs
that referenced
this pull request
Nov 12, 2026
Object IDs in internal/git are now an Oid, either a *SHA1 or a *SHA256, following gogs/git-module#140. Tree listings are parsed without assuming the length of an ID, and the empty ID of a reference update is recognized in either object format. Repositories can be created with a chosen object format from the web form and the API. Routes, references and links accept 64-character commit IDs, and a migration widens the database columns that store commit IDs to 64 characters. Co-authored-by: Linsen Zhou <i@lin.moe>
Member
|
I ported this pr and finished and co-authored you in gogs/gogs#8496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Link to the issue: #138
ObjectFormatstructObjectFormatstruct.*Repository.ObjectFormatmethod.ObjectFormatmember to theInitOptionstructOidinterfaceOidinterface to represent the Object ID of a Git repository.SHA256struct.*SHA1withOidin other struct fields, method parameters, and return types.sha1.gotooid.go.Add SHA256 Repository testing
test_sha256build tag to control testing variables and constants.testrepoMarksmap.Others
TestReceivePackandTestUploadPackfailures occurring on Git client v2.54.0 by updating the string matching patterns.Checklist