chore(monitoring): remove dead Prometheus rule ConfigMaps - #2092
chore(monitoring): remove dead Prometheus rule ConfigMaps#2092milandufek wants to merge 1 commit into
Conversation
These ConfigMaps are not read by anything. The last Prometheus able to load ConfigMap-based rules was deleted in 2023 (INFRA-2151). Alerting for this app is evaluated centrally by the Mimir ruler from PrometheusRule CRs in k8s-infra crs/kustomizations/mimir-rules-global/bear/. JIRA: GRIF-518 risk: low
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Limit details: You’ve used all 5 included reviews currently available. Your 8 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
Closes work for GRIF-518.
These
monitoring-rules.yaml/alertingRules.yamlConfigMaps are not read by anything:PrometheusRuleCRD. The kube-prometheus-stack ink8s-infrahas noruleFiles, noadditionalRulesConfigMapsand no rules sidecar, and Prometheus Operator never reads arbitrary ConfigMaps.configmap-reload+/etc/prometheus-rules) was deleted back in 2023 by INFRA-2151.monitoring-namespace PrometheusRules. Nothing from the app namespaces, nothing ConfigMap-sourced.Alerting for these apps is evaluated centrally by the Mimir ruler from
k8s-infra/crs/kustomizations/mimir-rules-global/bear/(thegeneric-<team>-rules.yamlfiles plus the app-specific ones).Removed
k8s/charts/lcm-bricks/templates/prometheus/alertingRules.yamlOther changes
k8s/charts/lcm-bricks/Chart.yamlChart versions are bumped so the CD pipeline accepts the rebuild. Values keys that existed only to feed the rules are dropped;
clusterIdis kept wherever another template still uses it.No alerting change.
k8s-infrais untouched, so the ruler's rule set is identical before and after.🤖 Generated with Claude Code