Skip to content

chore(monitoring): remove dead Prometheus rule ConfigMaps - #2092

Open
milandufek wants to merge 1 commit into
masterfrom
md-grif-518-remove-dead-monitoring-rules
Open

chore(monitoring): remove dead Prometheus rule ConfigMaps#2092
milandufek wants to merge 1 commit into
masterfrom
md-grif-518-remove-dead-monitoring-rules

Conversation

@milandufek

Copy link
Copy Markdown
Contributor

Closes work for GRIF-518.

These monitoring-rules.yaml / alertingRules.yaml ConfigMaps are not read by anything:

  • The only rule-discovery mechanism on our clusters is the PrometheusRule CRD. The kube-prometheus-stack in k8s-infra has no ruleFiles, no additionalRulesConfigMaps and no rules sidecar, and Prometheus Operator never reads arbitrary ConfigMaps.
  • The last Prometheus that could load ConfigMap-based rules (configmap-reload + /etc/prometheus-rules) was deleted back in 2023 by INFRA-2151.
  • Confirmed against live clusters: the per-cluster Prometheus in NA1 and EU1 loads only operator-generated rule files from monitoring-namespace PrometheusRules. Nothing from the app namespaces, nothing ConfigMap-sourced.

Alerting for these apps is evaluated centrally by the Mimir ruler from k8s-infra/crs/kustomizations/mimir-rules-global/bear/ (the generic-<team>-rules.yaml files plus the app-specific ones).

Removed

  • k8s/charts/lcm-bricks/templates/prometheus/alertingRules.yaml

Other changes

  • k8s/charts/lcm-bricks/Chart.yaml

Chart versions are bumped so the CD pipeline accepts the rebuild. Values keys that existed only to feed the rules are dropped; clusterId is kept wherever another template still uses it.

No alerting change. k8s-infra is untouched, so the ruler's rule set is identical before and after.

🤖 Generated with Claude Code

These ConfigMaps are not read by anything. The last Prometheus able to
load ConfigMap-based rules was deleted in 2023 (INFRA-2151). Alerting for
this app is evaluated centrally by the Mimir ruler from PrometheusRule CRs
in k8s-infra crs/kustomizations/mimir-rules-global/bear/.

JIRA: GRIF-518
risk: low
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 59 minutes

Limit details: You’ve used all 5 included reviews currently available. Your 8 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5ada5544-4b65-4613-9825-3a60ca882d09

📥 Commits

Reviewing files that changed from the base of the PR and between aa29f8e and 450cf5d.

📒 Files selected for processing (2)
  • k8s/charts/lcm-bricks/Chart.yaml
  • k8s/charts/lcm-bricks/templates/prometheus/alertingRules.yaml

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant