Move host_tests sandboxing harness into base/cvd - #3137
Open
dxapd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of this PR is mechanical stuff (moving files and adding the go toolchain) but it was also a convenient spot to add in the cvdalloc.go that will be needed with the final wiring change as well as the dnsmasq shim that goes with it (since dnsmasq itself cannot run in the namespaces we are making, but we don't really need it to).
So it also poses a good opportunity to review that file in isolation while we're at it. It's not wired up to any test in this PR, but if you want to see an example of it being used: https://github.com/dxapd/android-cuttlefish/blob/a8e54dc2a4e629bd1faab6487712e56cc9ec13f4/base/cvd/host_tests/cvdalloc_test/main_test.go