Repository navigation
Refactor metrics to use SplitMetricHelper - #5546
Merged
Merged
Conversation
ViniciustCosta
left a comment
ViniciustCosta
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall, please add evidence from this on development env
Contributor
Author
Done, added in the PR description. |
Collaborator
Just to confirm, are those the metrics from before and after the change? |
ViniciustCosta
approved these changes
Oct 21, 2026
Contributor
Author
No. I updated the PR description to explain what the screenshots are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR #5530 introduced a class named
SplitMetricHelper, which simplifies the emission of metrics that are grouped byFUZZERandJOB.This PR refactors the code to use
SplitMetricHelperwherever possible, reducing duplicated code. No behavior change is expected.Changes
None. Only refactoring.
Tests
No additional tests.
Tested in dev environment. Evidence (they show that FUZZER_TOTAL_FUZZ_TIME and JOB_TOTAL_FUZZ_TIME are being measured correctly):