Repository navigation
Authenticate googlesource.com requests behind a feature flag - #5547
Merged
Merged
Conversation
PauloVLB
force-pushed
the
gob-auth-source
branch
3 times, most recently
from
October 21, 2026 15:23
9fb3249 to
17b4d85
Compare
PauloVLB
marked this pull request as ready for review
October 21, 2026 15:23
decoNR
approved these changes
Oct 21, 2026
decoNR
left a comment
decoNR
left a comment
Contributor
There was a problem hiding this comment.
LGTM, please wait your test in dev to merge.
PauloVLB
force-pushed
the
gob-auth-source
branch
from
October 22, 2026 16:52
17b4d85 to
ce66892
Compare
PauloVLB
force-pushed
the
gob-auth-source
branch
from
October 22, 2026 17:25
ce66892 to
c0cd583
Compare
dylanjew
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/573204199
Problem
Anonymous requests to googlesource.com (GoB) are no longer covered by its SLO and are the first ones dropped when it's overloaded. We fetch DEPS files and commit info from chromium.googlesource.com without auth for the revision info in fuzzer logs, impact, blame and the testcase page (~16k requests a day).
Proposed solution
gob_authenticated_requestsfeature flag, googlesource.com requests go to the/a/path with the default service account token.cloud-platformscoped tokens, which the bots and App Engine already have, so there's nothing to provision.Validation
/a/request with the bot's token returns 200 (401 without it): https://screenshot-v2.corp.google.com/2psi3qh9f66qoIn dev, with the flag on:
I opened
/revisions?job=libfuzzer_chrome_asan&revision=1723778, which fetches that revision's DEPS from chromium.googlesource.com. The logs show the request going to the/a/URL with the App Engine service account, and the page returned 200 with the component revisions:On a dev bot, an impact task made the authenticated calls with the bot's service account, and they worked: right after each one it parsed the DEPS and V8 commit info (logs):
