Repository navigation
Normalize archive paths with posixpath and mark discovery builds partial - #5548
Draft
notvictorl wants to merge 1 commit into
Draft
notvictorl wants to merge 1 commit into
notvictorl wants to merge 1 commit into
Conversation
notvictorl
marked this pull request as draft
October 20, 2026 18:31
dylanjew
reviewed
Oct 22, 2026
| if not self.list_members(): | ||
| return '' | ||
| return os.path.commonpath([f.name for f in self.list_members()]) | ||
| # Member names always use '/', whatever the host OS, so don't use os.path |
Collaborator
There was a problem hiding this comment.
is this worth documenting at the class level?
| def is_fuzz_target(file_path, file_opener: Optional[Callable] = None): | ||
| """Returns whether |file_path| is a fuzz target binary (local path).""" | ||
| if '@' in file_path: | ||
| normalized_path = file_path.replace('\\', '/') |
Collaborator
There was a problem hiding this comment.
do we need any of these utils.py changes? Can we just limit the path normalization to build_archive.py and archive.py? Then these utils would continue to be OS agnostic.
Can you confirm whether or not Linux bots process Windows archives or manifests? If they do, then we could normalize once when extracting the fuzz targets, rather than each check.
Collaborator
Author
There was a problem hiding this comment.
No, we can probably limit it to the archive files.
Linux bots never process Windows archives or manifests so changes are not needed in utils.py.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip
b/563414378