Repository navigation
Fix: SplitMetricHelper shared labels dictionary - #5550
Merged
Merged
Conversation
| @@ -607,12 +607,13 @@ def __init__(self, fuzzer_metric: Metric, job_metric: Metric): | |||
| def insert(self, value: float, labels=None): | |||
| labels = dict(labels) if labels else {} | |||
| assert 'fuzzer' in labels and 'job' in labels | |||
Collaborator
There was a problem hiding this comment.
Since you are fixing a bug here, let's also remove this assert in favor of a check with error log and early return. We probably should not break the execution due to wrong label metric.
ViniciustCosta
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
PR #5530 introduced the class
SplitMetricHelper, used for emitting metrics that are duplicated (one metric grouped byFUZZERand another byJOB, likeFUZZER_TOTAL_FUZZ_TIMEandJOB_TOTAL_FUZZ_TIME). However, this class uses the samelabelsdictionary instance for bothFUZZERandJOBmetrics, and the_MetricsStorestore references to the dictionary. Thus, when emitting the metric to GCP, bothFUZZERandJOBmetrics end up with the same labels.Fix
Change
SplitMetricHelperto not use the same dictionary instance.