Repository navigation
Close temp file handle in libFuzzer engine - #5551
Merged
Merged
Conversation
On Windows, _create_empty_testcase_file leaked the fd returned by tempfile.mkstemp, so the bot process kept the file open and could not clear FUZZ_INPUTS afterwards (WinError 32 on every cleanup until reboot). Use utils.create_temp_file, which closes the fd.
IvanBM18
approved these changes
Oct 22, 2026
dylanjew
approved these changes
Oct 23, 2026
Xeicker
added
the
ready for GOSST review
decoNR
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only changing the closing handler,
clusterfuzz/src/clusterfuzz/_internal/base/utils.py
Lines 1157 to 1160 in 4b7781f
On Windows, _create_empty_testcase_file leaked the fd returned by tempfile.mkstemp, so the bot process kept the file open and could not clear FUZZ_INPUTS afterwards (WinError 32 on every cleanup until reboot). Use utils.create_temp_file, which closes the fd.
On non windows OSs the file descriptor can still be cleaned up, so no effect for those platforms