Repository navigation
Add golden tests for ComponentHjarGenerator. - #5371
Merged
Merged
Conversation
`HjarTest` only verified that hjar compilation succeeded without asserting on the generated source. Adding baseline golden files locks down the exact generated `Dagger<Component>` header stub before removing the `SourceFileHjarGenerator` wrapper in a follow-up change. Expand `HjarTest` to cover default builders, module setters, explicit `@Component.Builder` and `@Component.Factory`, `generatedClassExtendsComponent` overrides across primitive, reference, and `void` return types, abstract component `super(...)` constructor calls, and `@ProductionComponent`. RELNOTES=N/A PiperOrigin-RevId: 1026757741
copybara-service
Bot
force-pushed
the
test_1026656046
branch
from
November 20, 2026 22:34
d02dcc0 to
e1b33d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add golden tests for ComponentHjarGenerator.
HjarTestonly verified that hjar compilation succeeded without asserting on the generated source. Adding baseline golden files locks down the exact generatedDagger<Component>header stub before removing theSourceFileHjarGeneratorwrapper in a follow-up change.Expand
HjarTestto cover default builders, module setters, explicit@Component.Builderand@Component.Factory,generatedClassExtendsComponentoverrides across primitive, reference, andvoidreturn types, abstract componentsuper(...)constructor calls, and@ProductionComponent.RELNOTES=N/A