Recognize split declaration/assignment in UnnecessaryStringBuilder - #6069
Open
tanvir-ux wants to merge 1 commit into
Open
Recognize split declaration/assignment in UnnecessaryStringBuilder#6069tanvir-ux wants to merge 1 commit into
tanvir-ux wants to merge 1 commit into
Conversation
`StringBuilder x; x = new StringBuilder(...);` is observationally the same as `StringBuilder x = new StringBuilder(...);`, but the check only handled the combined declarator form. Teach it to treat a sole initializing assignment the same way, and ignore that assignment when deciding whether the local is still required to be a StringBuilder. Fixes google#5828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5828.
UnnecessaryStringBuilderalready flags locals like:but misses the equivalent split form:
This change treats a sole initializing assignment the same as a declarator
initializer, and ignores that assignment when checking whether the local
still needs to stay a
StringBuilder.Testing
All
UnnecessaryStringBuilderTestcases passed (including new split-form coverage).