Recognize split declaration/assignment in UnnecessaryAsync - #6070
Open
tanvir-ux wants to merge 1 commit into
Open
Recognize split declaration/assignment in UnnecessaryAsync#6070tanvir-ux wants to merge 1 commit into
tanvir-ux wants to merge 1 commit into
Conversation
`AtomicInteger a; a = new AtomicInteger(0);` is equivalent to `AtomicInteger a = new AtomicInteger(0);`, but the check required an initializer on the VariableTree. Find a sole initializing assignment, treat it like a declarator initializer for escape analysis, and delete that assignment statement when rewriting to a plain local. Fixes google#5829
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5829.
UnnecessaryAsyncalready flags locals like:but misses the equivalent split form:
This change finds a sole initializing assignment when the declarator has
no initializer, treats that assignment as non-escaping (same as the
combined form), and removes the assignment statement when applying the
suggested rewrite to a plain local.
Testing
All 13
UnnecessaryAsyncTestcases passed (including new split-form coverage).