feat(storage): Parameterized test setup for RCU Integration Testing

[nidhiii-27]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces support for a new PREPROD backend and expands the integration testing framework to support combinations of LocationType and Colocation configurations, including dynamic bucket creation and Rapid Cache setup. The review feedback highlights critical compilation errors in CrossRunIntersection.java due to missing static imports for requireNonNull, a potential resource leak in BackendResources.java during cleanup if a bucket fails to stop, and a robustness improvement for URL parsing in HttpStorageRpc.java.

[gemini-code-assist]

The method requireNonNull is called here but it is not statically imported in this file, which will cause a compilation error. Please use Objects.requireNonNull instead.

Suggested change

	requireNonNull(locationType, "locationType must be non null");
	Objects.requireNonNull(locationType, "locationType must be non null");

[gemini-code-assist]

The method requireNonNull is called here but it is not statically imported in this file, which will cause a compilation error. Please use Objects.requireNonNull instead.

Suggested change

	requireNonNull(colocation, "colocation must be non null");
	Objects.requireNonNull(colocation, "colocation must be non null");

[gemini-code-assist]

If any of the dynamic buckets fail to stop (e.g., due to a network issue or if the bucket was already deleted), the forEach loop will terminate abruptly. This will prevent the remaining dynamic buckets from being stopped, leading to resource leaks. Wrapping the stop() call in a try-catch block ensures that all buckets are processed.

Suggested change

	dynamicBuckets.values().forEach(BucketInfoShim::stop);
	dynamicBuckets.values().forEach(shim -> {
	try {
	shim.stop();
	} catch (Exception e) {
	// Suppress exception to ensure all dynamic buckets are stopped
	}
	});

References

1. In test cleanup or resource deletion logic, catching a broad Exception is acceptable to ensure that the cleanup process is not halted by individual failures.

[gemini-code-assist]

Using host.indexOf(path) to find the start of the path is generally safe here, but using host.length() - path.length() is more robust, direct, and avoids searching the string, as the path is guaranteed to be at the end of the host URL.

Suggested change

	String rootUrl = host.substring(0, host.indexOf(path));
	String rootUrl = host.substring(0, host.length() - path.length());