Skip to content

fix(bigquery-jdbc): record adoption features once per object - #15044

Draft
Neenu1995 wants to merge 8 commits into
mainfrom
jdbc-telemetry-updates
Draft

Neenu1995 wants to merge 8 commits into
mainfrom
jdbc-telemetry-updates

Conversation

@Neenu1995

@Neenu1995 Neenu1995 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

failsafe argLine: -Xmx1536m -XX:MaxDirectMemorySize=1g
-XX:+ExitOnOutOfMemoryError, in the base config (the [17,) profile never
applied on the java11 image) and repeated in that profile since Maven
replaces rather than merges a profile argLine. A future overrun now fails
as an OutOfMemoryError on a named test instead of a silent container kill.

@Neenu1995
Neenu1995 requested review from a team as code owners November 16, 2026 21:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request ensures that driver-internal database operations (such as connection validation, metadata queries, and pooled connection delegation) are not reported as user activity in usage telemetry. It introduces internal statement creation methods, tracks metadata retrieval and parameter binding to record them at most once, and improves error status reporting for Write API batch failures. Feedback from the review highlights a potential data race in BigQueryConnection.getMetaDataInternal() due to unsynchronized lazy initialization, and suggests replacing absolute local file paths in SKILL.md with relative paths.

@Neenu1995
Neenu1995 changed the base branch from main to turn-off-telemetry November 16, 2026 22:18
@Neenu1995
Neenu1995 requested review from a team as code owners November 16, 2026 22:18
@Neenu1995
Neenu1995 marked this pull request as draft November 16, 2026 22:19
@Neenu1995
Neenu1995 changed the base branch from turn-off-telemetry to main November 16, 2026 22:37
@Neenu1995
Neenu1995 changed the base branch from main to turn-off-telemetry November 16, 2026 22:38
… from tracked skills

It was swept into the main merge by accident; main tracks only the shared
bigquery-jdbc-testing and bigquery-jdbc-prepare-pr skills.
Base automatically changed from turn-off-telemetry to main November 17, 2026 00:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant