Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that driver-internal database operations (such as connection validation, metadata queries, and pooled connection delegation) are not reported as user activity in usage telemetry. It introduces internal statement creation methods, tracks metadata retrieval and parameter binding to record them at most once, and improves error status reporting for Write API batch failures. Feedback from the review highlights a potential data race in BigQueryConnection.getMetaDataInternal() due to unsynchronized lazy initialization, and suggests replacing absolute local file paths in SKILL.md with relative paths.
… from tracked skills It was swept into the main merge by accident; main tracks only the shared bigquery-jdbc-testing and bigquery-jdbc-prepare-pr skills.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failsafe argLine: -Xmx1536m -XX:MaxDirectMemorySize=1g
-XX:+ExitOnOutOfMemoryError, in the base config (the [17,) profile never
applied on the java11 image) and repeated in that profile since Maven
replaces rather than merges a profile argLine. A future overrun now fails
as an OutOfMemoryError on a named test instead of a silent container kill.