Repository navigation
feat(bigquery-jdbc): add job-stream reader for Arrow results - #15048
Open
keshavdandeva wants to merge 2 commits into
Open
keshavdandeva wants to merge 2 commits into
keshavdandeva wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements support for reading query job results directly from BigQuery job streams, rather than relying solely on read sessions. Key changes include updating BigQueryArrowBatchWrapper to track reported row counts, enhancing BigQueryArrowResultSet to validate row counts and handle stream errors more robustly, and adding functionality to BigQueryStatement to construct and read from job streams. Extensive unit tests were added to verify the new stream reading logic, error handling, and row count validation. I have no feedback to provide as there were no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/582677690
Adds a reader for a query job's
_defaultstream, so results can be read through the Storage Read API without creating a read session. Nothing calls it yet; Task 4 (b/582676785) wires it into statement execution.Changes
ReadRowsrequest. A resumed request is the first request with only the offset changed.row_countand decides nothing.BigQueryArrowResultSet.loadNextBatch()fails when a batch doesn't hold the rows its message reports.next()returns false, and getters throwSQLExceptionuntil then.Behaviour changes on the existing HTAPI path
row_countthat differs from the rows in the batch is now an error.next()returns false. Before, it read on from the following message.Testing
make lintandmake unittest: 1280 tests, 0 failures, 1 skipped in a class this PR doesn't touch.