feat(google/cloud/sql): onboard google-cloud-sql - #18180
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new google-cloud-sql package, which contains Python client libraries for the Cloud SQL Admin API (versions v1 and v1beta4), along with its associated documentation, metadata, and configuration files. The review feedback suggests configuring the library type as GAPIC_COMBO in both librarian.yaml and .repo-metadata.json to correctly handle this multi-version combined library.
| python: | ||
| opt_args_by_api: | ||
| google/cloud/sql/v1: | ||
| - resource-name-alias=backupdr.googleapis.com/Backup:BackupDRBackup | ||
| google/cloud/sql/v1beta4: | ||
| - resource-name-alias=backupdr.googleapis.com/Backup:BackupDRBackup | ||
| default_version: v1 |
There was a problem hiding this comment.
Since the google-cloud-sql package contains multiple API versions (v1 and v1beta4), it should be configured as a GAPIC_COMBO library under the python configuration in librarian.yaml to ensure correct handling by the monorepo tooling and documentation generator.
python:
library_type: GAPIC_COMBO
opt_args_by_api:
google/cloud/sql/v1:
- resource-name-alias=backupdr.googleapis.com/Backup:BackupDRBackup
google/cloud/sql/v1beta4:
- resource-name-alias=backupdr.googleapis.com/Backup:BackupDRBackup
default_version: v1| "distribution_name": "google-cloud-sql", | ||
| "issue_tracker": "https://issuetracker.google.com/issues/new?component=65246\u0026template=1161103", | ||
| "language": "python", | ||
| "library_type": "GAPIC_AUTO", |
There was a problem hiding this comment.
Update the library_type to GAPIC_COMBO to correctly reflect that this package is a multi-version combined library, matching the configuration in librarian.yaml.
| "library_type": "GAPIC_AUTO", | |
| "library_type": "GAPIC_COMBO", |
quirogas
added
the
do not merge
quirogas
changed the title
|
Do not merge until #18013 has been merged. |
1 participant
Onboard google-cloud-sql package. Fixes b/537730936, b/537731748