Repository navigation
fix(google-crc32c): license formatting in pyproject.toml - #18967
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
ohmayr
approved these changes
Nov 3, 2026
ohmayr
added a commit
that referenced
this pull request
Nov 4, 2026
This PR is needed to unblock #18967 where the windows build is failing with ``` ERROR: Exception: Traceback (most recent call last): File "C:\Program Files\Python310\lib\site-packages\pip\_internal\cli\base_command.py", line 110, in _run_wrapper status = _inner_run() File "C:\Program Files\Python310\lib\site-packages\pip\_internal\cli\base_command.py", line 103, in _inner_run return self.run(options, args) File "C:\Program Files\Python310\lib\site-packages\pip\_internal\cli\req_command.py", line 162, in wrapper return func(self, options, args) File "C:\Program Files\Python310\lib\site-packages\pip\_internal\commands\install.py", line 729, in run _eagerly_import_modules(module_names) File "C:\Program Files\Python310\lib\site-packages\pip\_internal\commands\install.py", line 176, in _eagerly_import_modules __import__(module) File "C:\Program Files\Python310\lib\site-packages\readline.py", line 34, in <module> rl = Readline() File "C:\Program Files\Python310\lib\site-packages\pyreadline\rlmain.py", line 422, in __init__ BaseReadline.__init__(self) File "C:\Program Files\Python310\lib\site-packages\pyreadline\rlmain.py", line 62, in __init__ mode.init_editing_mode(None) File "C:\Program Files\Python310\lib\site-packages\pyreadline\modes\emacs.py", line 633, in init_editing_mode self._bind_key('space', self.self_insert) File "C:\Program Files\Python310\lib\site-packages\pyreadline\modes\basemode.py", line 162, in _bind_key if not callable(func): File "C:\Program Files\Python310\lib\site-packages\pyreadline\py3k_compat.py", line 8, in callable return isinstance(x, collections.Callable) AttributeError: module 'collections' has no attribute 'Callable' ``` I filed #18972 for the follow up issue to audit builds that are still using Python 3.10 and upgrade them Co-authored-by: ohmayr <omairn@google.com>
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gentoo QA complains:
Duplicate of #18950 that got automatically closed after I git cloned my patch with depth 1 and tried to amend the commit, resulting in squashing the whole repo...