Skip to content

feat(ces): regenerate v1beta with resource alias - #18975

Merged
ohmayr merged 1 commit into
mainfrom
fix/ces-service-resource-alias
Nov 3, 2026
Merged

ohmayr merged 1 commit into
mainfrom
fix/ces-service-resource-alias

Conversation

@ohmayr

@ohmayr ohmayr commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Context & Problem

Regenerating google-cloud-ces (google/cloud/ces/v1beta) fails in protoc-gen-python_gapic because google/cloud/ces/v1beta now references both servicedirectory.googleapis.com/Service and agentregistry.googleapis.com/Service, which collide on service_path. Generation was temporarily disabled via skip_generate: true in librarian.yaml.

Summary of Changes

  • Add resource-name-alias=agentregistry.googleapis.com/Service:AgentRegistryService under python.opt_args_by_api for google/cloud/ces/v1beta in librarian.yaml (matching google/cloud/ces/v1beta/BUILD.bazel and preserving backward compatibility for service_path).
  • Remove skip_generate: true and the temporary skip comment for google-cloud-ces in librarian.yaml.
  • Regenerate packages/google-cloud-ces using librarian v0.51.0.

Verification

  • Ran librarian tidy and librarian generate google-cloud-ces with librarian v0.51.0 (exit code 0).
  • Ran unit test suite (pytest -n auto tests/unit in packages/google-cloud-ces): 5,850 passed.
  • Ran PYENV_VERSION=py314 nox -s lint (ruff import/format checks + flake8): passed.

Fixes #18888

Alias agentregistry.googleapis.com/Service to AgentRegistryService in
librarian.yaml so servicedirectory.googleapis.com/Service retains the
existing service_path helper without colliding during GAPIC generation.
Remove skip_generate and regenerate google-cloud-ces with Librarian
v0.51.0.

Fixes #18888
@ohmayr
ohmayr requested review from a team as code owners November 3, 2026 19:54
@snippet-bot

snippet-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 20 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the generation of the google-cloud-ces library and introduces the AssistantService with support for managing assistant sessions, running assistant agents, and streaming AI assistant chats. Additionally, it adds several new features and updates across existing services, including the UpdateAppVersion RPC in AgentService, new streaming and onboarding suggestion RPCs in SessionService, support for remote A2A agents, custom voice samples, thinking level configurations, and supervisor guardrails. I have no feedback to provide as there are no review comments.

@ohmayr
ohmayr merged commit be426ad into main Nov 3, 2026
54 checks passed
@ohmayr
ohmayr deleted the fix/ces-service-resource-alias branch November 3, 2026 22:25
@release-please release-please Bot mentioned this pull request Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[google-cloud-ces] Generation fails on google/cloud/ces/v1beta due to Service resource namespace collision

2 participants