Repository navigation
chore(bigtable): deprecate legacy handwritten Client and Instance admin methods - #19001
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates several methods and properties in client.py and instance.py in favor of using google.cloud.bigtable_admin_v2 clients, adding deprecation docstrings and warnings. Feedback on the changes suggests removing an unnecessary else block in Instance.create to simplify the code, as the preceding conditional blocks already raise exceptions.
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
approved these changes
Nov 6, 2026
…in methods Add DeprecationWarning and Sphinx deprecated directives to handwritten admin methods on Client and Instance in favor of BigtableInstanceAdminClient and BigtableTableAdminClient.
…tance admin methods Keep only the Sphinx .. deprecated:: 2.30.0 docstring notices without emitting runtime warnings.
mutianf
force-pushed
the
deprecate-legacy-instance-admin
branch
from
November 6, 2026 17:48
13a045a to
4fc2752
Compare
mutianf
enabled stacked auto-merge (squash)
November 6, 2026 17:48
stacked auto-merge was automatically disabled
November 6, 2026 19:00
Auto-merge was disabled for another pull request in the stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕