Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates several legacy methods in the Backup and Table classes of the google-cloud-bigtable package, directing users to use BigtableTableAdminClient instead. The changes add deprecation notices to docstrings and introduce runtime warnings.warn calls. Feedback highlights that the column_family and backup methods in table.py received docstring deprecation updates but are missing corresponding runtime warning calls, which should be added for consistency.
daniel-sanche
approved these changes
Nov 6, 2026
mutianf
force-pushed
the
deprecate-legacy-table-backup-admin
branch
from
November 6, 2026 17:48
e614a44 to
1815a71
Compare
mutianf
enabled stacked auto-merge (squash)
November 6, 2026 17:48
mutianf
disabled stacked auto-merge
November 6, 2026 19:00
…methods Add DeprecationWarning and Sphinx deprecated directives to legacy handwritten admin methods on Table and Backup in favor of BigtableTableAdminClient.
…up admin methods Keep only the Sphinx .. deprecated:: 2.30.0 docstring notices without emitting runtime warnings.
mutianf
force-pushed
the
deprecate-legacy-table-backup-admin
branch
from
November 6, 2026 19:00
1815a71 to
bc4e03a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕