[founderinaction]

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #18375 🦕

Database.run_in_transaction sets _local.transaction_running = True and then calls get_session() outside the try/finally that resets the flag. If checkout raises, for example ServiceUnavailable while Spanner is down, the flag is never cleared. Every later call on that thread then fails with RuntimeError: Spanner does not support nested transactions, even after Spanner recovers.

The change moves session checkout inside the try, and only calls put_session when a session was actually obtained, so None is never returned to the sessions manager. The async implementation in _async/database.py had the same shape. I fixed it there and made the identical change to the generated sync module, and checked that the CrossSync conversion of the async method matches the sync one.

Tests, sync and async:

• test_run_in_transaction_session_error: the first checkout raises ServiceUnavailable, and a second call succeeds. The failed attempt doesn't call put_session, the flag is reset, and the session from the second call is returned.
• test_run_in_transaction_callback_error: when the callback raises, the flag is reset and the session is still returned. This pins the existing behaviour.

Without the fix, both session_error tests fail with the nested-transaction RuntimeError. With it, tests/unit passes, and ruff and flake8 are clean.

@mukeshr06 reproduced this in September and mentioned preparing a fix. I haven't seen a PR since, so here is one. Happy to close this in favour of theirs if it's close.

[gemini-code-assist]

Code Review

This pull request modifies the run_in_transaction method in both the synchronous and asynchronous database implementations to initialize the session variable to None and safely retrieve it within the try block. In the finally block, the session is only returned to the session manager if it was successfully created (i.e., is not None). This prevents secondary errors when session retrieval fails. Corresponding unit tests have been added to verify error handling during session retrieval and callback execution. There are no review comments, so I have no feedback to provide.