Repository navigation
ci: fix zizmor findings in workflows - #796
Merged
Merged
Conversation
jokerttu
marked this pull request as ready for review
November 5, 2026 11:49
jokerttu
force-pushed
the
pin-action-hashes
branch
2 times, most recently
from
November 5, 2026 12:12
e532788 to
cad35de
Compare
jokerttu
force-pushed
the
pin-action-hashes
branch
from
November 5, 2026 14:38
cad35de to
4280b77
Compare
illuminati1911
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Medium findings that make the zizmor
GitHub Actions Scanfail (exit code 13).Unpinned actions. Pins every
uses:reference in.github/workflows/to a full commit hash, which the zizmor blanketunpinned-usespolicy requires. Each pin carries a# vX.Y.Zcomment naming the release it points to.The three refs that were still on a tag (
actions/setup-java@v4,actions/cache/restore@v4,actions/cache/save@v4inanalyze.yaml) now use the same hashes the other workflows already pin for those actions: setup-java v4.9.1 and cache v4.3.0. These three were the mandatory zizmor findings on #795.Workflow permissions.
analyze.yamlandlicence-check.yamlhad nopermissions:block, so they ran with the default token permissions (excessive-permissions). Both now declarecontents: readat the top level, the same blocktest-and-build.yamlalready uses. Their jobs only check out code and run local tools; none use the token.Why it's safe: no action changes major version, and none of the hashes that were already pinned change. The only behavior change is that
setup-javaandcacheinanalyze.yamlrun fixed releases inside v4 instead of the movingv4tag.subosito/flutter-actionstays at v2.23.0. It resolves3.47.xat runtime by prefix match against Flutter's release manifest (setup.sh,filter_by_version), and that manifest lists stable 3.47 releases.bluefireteam/melos-actionstays on its existing pin, an untagged commit after v3.0.0, so it has no version comment.Bumping actions to newer major versions is left to #771.
Pre-launch Checklist