Fix installer PATH setup for fish and other shells - #79
Open
catwinee wants to merge 1 commit into
Open
Conversation
curl | bash always sets BASH_VERSION, so fish and other non-bash users got a bash export written to the wrong rc file. Write a shell-specific snippet instead and skip duplicates on reinstall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl | bashalways setsBASH_VERSION, so the installer wroteexport PATH=...into.bashrceven when the user's login shell was fish/zsh/nushell. Detect$SHELLinstead and write a matching snippet (fish_add_pathfor fish, Nushellenv.nu, cshsetenv, etc.).$HOME/.local/binis already present, so re-running the installer no longer duplicates PATH lines.Test plan
curl ... | bash(orbash install.sh) and confirm it appendsfish_add_path "$HOME/.local/bin"to~/.config/fish/config.fish, notexport PATHto.bashrcsource ~/.config/fish/config.fish(or open a new fish session) thencommand -v popcorn-clisucceedsexport PATH="$HOME/.local/bin:$PATH"in.bashrc/.zshrc