Repository navigation
Conversation
…on-ASCII signatures parse_signature_header converted the timestamp to a datetime outside its try/except, so out-of-range timestamps raised ValueError/OverflowError, and non-ASCII signatures raised TypeError from hmac.compare_digest. Treat all of these as invalid signatures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nlathia
enabled auto-merge (squash)
November 13, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Webhook.parse_eventis documented to raiseSignatureVerificationErrorfor bad signatures, but some malformed headers escaped as other exceptions:t=253402300800,...->ValueError(year 10000)t=10**30,...->OverflowError; negative out-of-range ->ValueErrorv1=value ->TypeErrorfromhmac.compare_digestCallers catching only
SignatureVerificationErrorcould return a 500 instead of rejecting the request. No auth bypass; this is hardening.Change
tryinparse_signature_header, before any HMAC work.TypeErrorfrom the signature comparison.WebhookSignature(valid=False, timestamp=None).Tests
Added parametrized tests for
parse_signature_headerandparse_eventcovering all four cases.uv run pytest tests: 36 passed.🤖 Generated with Claude Code