Repository navigation
feat: refuse requests for a chain the subgraph doesn't index - #758
Open
MoonBoi9001 wants to merge 4 commits into
Open
MoonBoi9001 wants to merge 4 commits into
MoonBoi9001 wants to merge 4 commits into
Conversation
The CLI reads which network a subgraph indexes from its manifest and looks up the chain ID. That logic moves into dipper-core behind a manifest feature, so the service can reuse it.
A request's chain was trusted as sent, so a wrong one priced and placed agreements on another chain. Requests for indexers are now checked against the manifest on IPFS; cancels are not.
IPFS takes about 30s to say a manifest is missing, past the 10s wait, so it was retried forever. A 4xx is now final, the wait is 45s and the CLI shares the read. Errors and logs leave out the IPFS URL, which can carry credentials, and a zero wait is refused at startup.
The consumer skips a Studio record whose chain does not match its manifest, and Studio is never told. It now logs studio_request_chain_refused, which is in the default alert list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dipper reads each requested subgraph's manifest from IPFS and refuses a request for indexers whose chain doesn't match it or whose manifest IPFS lacks, while cancels skip the check so a request stored under the wrong chain can still be closed. If IPFS can't be reached the admin RPC answers 503 and the Studio consumer retries, a dropped Studio request raises the
studio_request_chain_refusedalert, andrequest_chain_check.enabledturns the check off.