Repository navigation
fix: cap the base price on chains without their own ceiling - #763
Draft
MoonBoi9001 wants to merge 3 commits into
Draft
MoonBoi9001 wants to merge 3 commits into
MoonBoi9001 wants to merge 3 commits into
Conversation
Only the 9 rollout chains had a base-price ceiling, so on any other chain an indexer could ask any base price and still be picked. A fallback ceiling now covers every chain without its own entry, by default the highest chain ceiling (4,500 GRT per 30 days).
The default fallback ceiling was worked out by building the whole default chain map, and its comment implied it follows an operator's own chain ceilings, which it does not.
An infinite ceiling would let every indexer through rather than shut them out, so the test's name now says it rejects anything that is not a positive number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dipper sent IISA a base-price ceiling only for the 9 rollout chains, so on any other chain an indexer could ask any base price and still be selected. Those chains now get
fallback_max_grt_per_30_days, which defaults to 4,500 GRT per 30 days, and dipper refuses to start if it is not a positive number. IISA scores base price against the ceiling it is sent, so prices on those chains now score against 4,500 too.