Repository navigation
fix(staking): reconcile active stake and thawing balances after slashing - #341
Open
juanmardefago wants to merge 1 commit into
Open
juanmardefago wants to merge 1 commit into
juanmardefago wants to merge 1 commit into
Conversation
Exclude idle stake from Horizon Indexer ratios and overdelegation dilution by using provisionedTokens minus thawingTokens. Preserve the existing stake basis explicitly for legacy metric calculations, including indexers that retain their legacy flag after migrating to Horizon. Mirror the contracts' proportional reduction of thawing balances when provider stake or delegation is slashed, including integer rounding. Update the corresponding Indexer and network/service aggregates before recalculating metrics, and refresh the delegation exchange rates. Network and service delegation totals already exclude thawing tokens, so subtract only the active portion of a delegation slash from those totals. Keep the full slash amount in gross balances and cumulative slashing totals. Add 12 regression tests covering idle stake, deprovisioning, partial and full slashes, rounding, aggregate balances, exchange rates, and legacy metrics. Extend the existing deprovisioning test to check Indexer cuts. Validation: - L1 and L2 codegen and builds passed. - All 144 tests passed under each configuration. - Targeted ESLint passed with four existing unused-variable warnings. - git diff --check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude idle stake from Horizon Indexer ratios and overdelegation dilution by using provisionedTokens minus thawingTokens. Preserve the existing stake basis explicitly for legacy metric calculations, including indexers that retain their legacy flag after migrating to Horizon.
Mirror the contracts' proportional reduction of thawing balances when provider stake or delegation is slashed, including integer rounding. Update the corresponding Indexer and network/service aggregates before recalculating metrics, and refresh the delegation exchange rates.
Network and service delegation totals already exclude thawing tokens, so subtract only the active portion of a delegation slash from those totals. Keep the full slash amount in gross balances and cumulative slashing totals.
Add 12 regression tests covering idle stake, deprovisioning, partial and full slashes, rounding, aggregate balances, exchange rates, and legacy metrics. Extend the existing deprovisioning test to check Indexer cuts.
Validation: