Repository navigation
Pin apple-private-apis: a wrong SMS code can be retyped - #15
Merged
Merged
Conversation
On Apple's -21669 ("Try entering your verification code again.") the
login now asks for the code again for the same text instead of failing
with Bad2faCode. The 2FA closure takes a TfaPrompt (the texted phone,
plus how many codes Apple has refused for this text) and returns
Option<String>; the console callers in src/test.rs ignore the prompt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JvDrSTtCSuxsh3iMaZ8sPX
Moves the submodule to the head of apple-private-apis#8, which retypes a refused code only when -21669 is Apple's sole reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018qVCoJNNwwmBEafaSpCBiG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
apple-private-apissubmodule to28fde51, the head of gregakespret/apple-private-apis#8. With it, a wrong SMS code that Apple will take another try for (-21669) no longer failsAppleAccount::login. The login asks the 2FA prompt again for the same text, and no new text is sent.The 2FA closure becomes
Fn(TfaPrompt) -> Option<String>.TfaPromptcarries the texted phone, as before, andrefused, how many codes Apple has refused for this text. The two console closures insrc/test.rsignore the prompt and wrap their input inSome. The library itself has no other callers of the closure.cargo test --lib: 13 passed.cargo check --bin rustpush-test --features macos-validation-datapasses. Therustpush-testbinary's own#[test] fn test()ends in an unconditionalpanic!, so a fullcargo testfails on it, with or without this change.Unverified against Apple: whether the same sign-in accepts a second code. Apple's -21669 reply invites one ("Try entering your verification code again."), and the first production retype will show it.
Merge after apple-private-apis#8, with a merge commit, not a squash. gregakespret/export-findmy#28 pins
Cargo.locktoba58bdd, this PR's head, onfix/mac-escrow-identity, and a merge commit keeps that commit on the branch.This conflicts with #9, which changes the same closure argument to
CodeSentTo.🤖 Generated with Claude Code
https://claude.ai/code/session_018qVCoJNNwwmBEafaSpCBiG