Repository navigation
Pin apple-private-apis to the default-phone change - #16
Merged
Merged
Conversation
Moves the submodule to 6557333, where the SMS code goes to Apple's default trusted phone and the 2FA prompt answers with `TfaAnswer` (a code, or another phone to text). The two console prompts in src/test.rs answer with `TfaAnswer::Code`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018qVCoJNNwwmBEafaSpCBiG
Moves the submodule to 1eaf3e0: a phone switch Apple will not send goes back to the text already sent instead of failing the sign-in, and TfaPrompt gains `texts` and `switch_refused`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018qVCoJNNwwmBEafaSpCBiG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
apple-private-apissubmodule from28fde51to1eaf3e0, the head of gregakespret/apple-private-apis#10. With it,AppleAccount::logintexts the SMS code to Apple's default trusted phone (trustedPhoneNumber) instead of phone id 1, and the 2FA prompt can answer "text this other phone instead". A switch Apple will not send leaves the login on the text already sent.The 2FA closure becomes
Fn(TfaPrompt) -> Option<TfaAnswer>.TfaPromptcarries the account's trusted phones (masked numbers and ids), the phone texted with the reason for it, Apple's default id,texts(texts sent this sign-in),switch_refused, andrefusedas before;sent_to()is now a method.TfaAnswerisCode(String)orTextPhone(id). The two console closures insrc/test.rsanswer withTfaAnswer::Code. The library has no other callers of the closure.The range also brings in d533ea8, already on the apple-private-apis base branch but never pinned here: a failed GSA
init,completeorvalidaterequest logs Apple's full reply at warn. Merging this turns that logging on in production.cargo test --lib: 13 passed.cargo check --bin rustpush-test --features macos-validation-datapasses. Therustpush-testbinary's own#[test] fn test()ends in an unconditionalpanic!, so a fullcargo testfails on it, with or without this change.Merge after apple-private-apis#10, with a merge commit, not a squash. gregakespret/export-findmy#30 pins
Cargo.lockto77fb266, this PR's head, onfix/mac-escrow-identity, and a merge commit keeps that commit on the branch.This conflicts with #9, which changes the same closure argument.
🤖 Generated with Claude Code
https://claude.ai/code/session_018qVCoJNNwwmBEafaSpCBiG