Repository navigation
test: verify complete nested npm lock dependency review - #2501
Closed
groupthinking wants to merge 10 commits into
Closed
groupthinking wants to merge 10 commits into
groupthinking wants to merge 10 commits into
Conversation
Bumps the npm_and_yarn group with 4 updates in the /docs/knowledge_prototypes/mcp-servers/fetch-mcp directory: [@modelcontextprotocol/sdk](https://github.com/modelcontextprotocol/typescript-sdk), [brace-expansion](https://github.com/juliangruber/brace-expansion), [fast-uri](https://github.com/fastify/fast-uri) and [proxy-addr](https://github.com/jshttp/proxy-addr). Bumps the npm_and_yarn group with 1 update in the /sdk/typescript directory: [brace-expansion](https://github.com/juliangruber/brace-expansion). Updates `@modelcontextprotocol/sdk` from 1.26.0 to 1.31.0 - [Release notes](https://github.com/modelcontextprotocol/typescript-sdk/releases) - [Commits](modelcontextprotocol/typescript-sdk@v1.26.0...1.31.0) Updates `brace-expansion` from 1.1.18 to 1.1.21 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.18...v1.1.21) Updates `brace-expansion` from 2.1.4 to 2.1.7 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.18...v1.1.21) Updates `fast-uri` from 3.1.7 to 3.1.8 - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.7...v3.1.8) Updates `proxy-addr` from 2.0.7 to 2.0.8 - [Release notes](https://github.com/jshttp/proxy-addr/releases) - [Changelog](https://github.com/jshttp/proxy-addr/blob/master/HISTORY.md) - [Commits](jshttp/proxy-addr@v2.0.7...v2.0.8) Updates `brace-expansion` from 1.1.13 to 1.1.21 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.18...v1.1.21) --- updated-dependencies: - dependency-name: "@modelcontextprotocol/sdk" dependency-version: 1.31.0 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: brace-expansion dependency-version: 1.1.21 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: brace-expansion dependency-version: 2.1.7 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: fast-uri dependency-version: 3.1.8 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: proxy-addr dependency-version: 2.0.8 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: brace-expansion dependency-version: 1.1.21 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
documentation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
This was referenced Oct 28, 2026
groupthinking
added a commit
that referenced
this pull request
Oct 29, 2026
## Current status — approved exact-head repair Head `85f1815ddb7ec121680d067d165e18eb40d90eda` targets `main` at merge commit `e010c9f3cec5ae72be16814d0841578ea9f8ded2`, after [#2487](#2487) merged at exact head `148cbf55fdce412255d2a61780459143521fa4c4`. The verified merge commit has the same tree as that head, so this PR's seven-file diff is unchanged. It adds complete npm lockfile coverage, preserves the scoped `uv.lock` classification, and combines both lock types into one manual snapshot so GitHub's pinned review action can compare the full base and head graphs. The controlled [#2501](#2501) test passed on an exact four-file dependency update. This has **not** yet produced a passing dependency comparison against the current `main` or cleared the original review queue. The exact-head [dependency review run 40760369080](https://github.com/groupthinking/EventRelay/actions/runs/40760369080) succeeded through its **code-only no-delta** path: the full-tree and combined lock submissions were correctly skipped because this PR changes workflow code and tests, not dependency inputs. Before the automatic base retarget, all 30 hosted checks at this same code head finished: **27 successful, 3 skipped, zero failed or pending**. The retarget did not run a new dependency comparison. A green no-delta check does not substitute for the controlled #2501 dependency test or a postmerge real PR test. A description-only edit may rerun metadata checks. ## Canonical issue Fixes #2505 on merge under the repository's issue-link rule. Parent #2490 stays open until a repaired `main` snapshot and a refreshed real dependency PR pass the full comparison. #2487 merged at the approved head, and GitHub automatically retargeted this draft to `main` at `e010c9f3cec5ae72be16814d0841578ea9f8ded2`. The head and seven-file diff remain unchanged. Hayden approved marking this exact head ready and merging it. Main-based dependency comparison remains a required postmerge verification. ## Changes - Remove focused one-ecosystem snapshot staging from `.github/workflows/dependency-review.yml`. Submit the same full-tree component-detection scan on `main` pushes and same-repository dependency PR heads at the exact commit SHA and ref. Keep the verified upstream component-detection v0.2.0 pin from #2397 and the existing severity, license and advisory policy. - Treat Dependabot configuration changes as configuration, and compare a PR head to its merge base when detecting new dependency inputs. A stale branch cannot turn a change made only on `main` into a dependency update in that PR. Real changed manifests and locks remain subject to review. - Include **every distinct name/version** from the tracked npm lockfiles, including nested second versions that component detection can omit. Group duplicate installed paths with runtime scope if any path is runtime. Submit those npm manifests and the scoped root `uv.lock` manifest in **one** manual snapshot after the full-tree scan. The scoped uv manifest treats packages reached only through `dev` or `docs` as development. The evidence recorder rejects missing, extra, wrong-manifest, wrong-version or wrong-scope rows against the exact changed lockfiles. - Increase the bounded per-file Python `PipReport` scan from 120 to 240 seconds and the job window to 30 minutes after an observed timeout produced unrelated requirements-file removals. A timeout still falls back to declared dependencies and can omit transitive packages; the guard rejects unrelated graph drift. Keep the 600-second snapshot-warning retry and warning rejection. - Add regression coverage for workflow selection, stale branches, npm nested versions and duplicate scope, combined one-request submission, scoped uv reachability, and exact evidence validation. ## Changed paths - `.github/workflows/dependency-review.yml` - `scripts/ci/record_dependency_review.py` - `scripts/ci/submit_npm_lock_snapshot.py` - `scripts/ci/submit_uv_lock_snapshot.py` - `tests/unit/test_dependency_review_workflow.py` - `tests/unit/test_submit_npm_lock_snapshot.py` - `tests/unit/test_submit_uv_lock_snapshot.py` ## Validation - Focused workflow, recorder, npm and uv snapshot suite: `uv run --no-project --with pytest --with pyyaml python -m pytest -q -o addopts='' tests/unit/test_submit_npm_lock_snapshot.py tests/unit/test_submit_uv_lock_snapshot.py tests/unit/test_dependency_review_workflow.py` — **31 passed in 3.10s** at the source head. `uv run --no-project --with ruff ruff check` and `ruff format --check` on those affected Python files, plus `git diff --check`, passed. - Controlled uv [#2499](#2499) used the exact `uv.lock` delta from original #2486 on matching off-main branches. Final [hosted run 40738274345, attempt 2](https://github.com/groupthinking/EventRelay/actions/runs/40738274345) passed policy, recorder and upload with **65 exact rows** (34 additions, 31 removals), correct package names, versions, manifests and development scopes, and no reported vulnerabilities. `ddtrace-internal` had unknown license metadata. The first attempt raced the base snapshot; the unchanged rerun passed. #2499 was closed unmerged. - Earlier controlled [#2500](#2500) used original #2355's exact two npm lockfile changes and exposed a **10/12 coverage gap** in component detection: nested development `brace-expansion` 2.1.4→2.1.7 was missing. Independent local npm audits of both lockfiles found no new advisory and fewer findings after the update (fetch 18→14; SDK 10→9). That green hosted check was insufficient; #2500 was closed unmerged. - Final controlled [#2501](#2501) used the exact four-file #2355 patch between base `eb6e556ef9eb8df80250613291c73abfb59b9f0e` and head `050f211b9715918f52c488a912d3ae797e76d68e`. [Base run 40759330706](https://github.com/groupthinking/EventRelay/actions/runs/40759330706) submitted the full-tree and combined lock snapshots; [head run 40759346059](https://github.com/groupthinking/EventRelay/actions/runs/40759346059) passed policy, recorder and upload. Its artifact and independent GitHub comparison contain **all 12 exact lock changes**, only from the two changed npm locks, with the nested `brace-expansion` row, correct scopes, zero added vulnerabilities, and added licenses MIT or BSD-3-Clause. GitHub's comparison with the review action's `per_page=5` request is also warning free. #2501 was closed unmerged; its temporary refs were deleted. - The final #2501 success followed two diagnosed issues: an unchanged Python requirements file generated 83 false removals after a 120-second fallback, and the pinned review action's five-item API page returned a **0-base/3-head** warning when full-tree, uv and npm were submitted separately (six snapshots across both sides). The same comparison with a larger page was warning free and had the correct 12 rows. Combining uv and npm manifests leaves two submissions per side and yielded the passing hosted result. Earlier #2493–#2496 diagnostics documented the initial main snapshot mismatch, the upstream manifest mapping update and scope validation; those results remain historical evidence, not a main-based pass. ## Remaining gates - [x] #2487 merged at its approved head; this draft automatically retargeted to `main`, and its unchanged seven-file diff was reviewed. - [x] Complete npm lock coverage and correct uv scope demonstrated in controlled hosted canaries, with the five-item review comparison warning free on #2501. - [x] Exact-head #2492 code-only dependency check and other hosted checks passed or skipped before the base retarget (27 successful, 3 skipped). This does not prove a main-based dependency update comparison. - [x] Hayden approved marking exact head `85f1815ddb7ec121680d067d165e18eb40d90eda` ready and merging #2492 after review of the main snapshot uncertainty. - [ ] After the merge, confirm the new `main` full-tree and combined lock submission, refresh one original manifest-changing PR onto that main, and require a warning-free hosted policy verdict plus complete artifact matching its actual dependency files. Then refresh and recheck the remaining original dependency PRs. Do not claim the original 21 dependency failures are resolved until this passes. - [ ] Resolve any outstanding review findings and merge decisions for the original PRs independently of this shared repair.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controlled nested npm dependency diagnostic
References original #2355 and shared repair #2492. This diagnostic is not for merge. Its final base
eb6e556ef9eb8df80250613291c73abfb59b9f0eand head050f211b9715918f52c488a912d3ae797e76d68ediffer by exactly the four files in #2355, with a byte-identical patch (SHA-256edf7379a3a0952837d2aa8539e811741b7889cdfcf27649330b470b8d0badc85). Neithermainnor original #2355 changed.Result
Final base run 40759330706 submitted the full-tree snapshot and one combined npm/uv lock snapshot successfully. Final head run 40759346059 passed the hosted dependency policy, evidence recorder, and artifact upload. The artifact's
review_outcomeissuccess. It contains 12 changes across only the two changed npm lockfiles: six additions and six removals, including the previously omitted nested developmentbrace-expansion2.1.4→2.1.7. The recorder's exact-lock check and an independent fresh GitHub comparison match every name, version, manifest, and scope. GitHub's comparison with the review action's ownper_page=5setting returns the same 12 rows and no snapshot warning. No added row has a reported vulnerability; the added licenses are MIT or BSD-3-Clause.Focused workflow, recorder, uv, and npm snapshot tests passed 31/31; Ruff lint and format and
git diff --checkpassed. Earlier clean npm installs/builds in both affected packages and fetch Jest 10/10 passed for the four-file update. This is controlled off-main evidence; the original queue still needs a repairedmainsnapshot, refreshed dependency PR heads, and exact hosted comparisons.Diagnostics retained
GITHUB_TOKEN; that was corrected before the tested result.lru-cachescope rows from an unchanged root lockfile. Grouping identical npm name/version entries with runtime precedence removed that drift.PipReportfallback. Its unchanged second attempt retained the stale comparison. The per-file bound was raised to 240 seconds and the job window to 30 minutes; this reduces the observed fallback risk but does not prove deterministic transitive Python resolution.actions/dependency-review-actionfailed both attempts. Its client requestsper_page=5; with three snapshots per side, that request returned a 0-base/3-head warning and thousands of unrelated additions, including pre-existingauthlibadvisories. The same commit comparison without pagination, or withper_page=30or100, returned warning-free 12 rows. Combining scoped uv and complete npm lock manifests into one manual snapshot leaves two submissions per side and produced the final passing hosted result above.The tested repair is now saved on draft #2492 at
85f1815ddb7ec121680d067d165e18eb40d90eda. Keep this diagnostic closed unmerged and remove both temporary refs after verifying this description and the final artifact. No merge decision for #2492 is implied by this result.