Repository navigation
fix(docker): agent image builds again from main - #61
Merged
Merged
Conversation
zlib-sync, added with the Discord adapter, compiles with node-gyp during npm install. node:24-slim has no Python or compiler, so the agent image build failed and main could not deploy. The tools go in the builder stage only; production copies the compiled modules. Closes: foreman-tqq3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The root postinstall runs scripts/check-dep-uniqueness.mjs, which the builder stage never copied, so npm install failed once zlib-sync compiled. Copying it also keeps the single-version check in the image build. Refs: foreman-tqq3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
maincan't deploy: the agent image build fails atnpm install.zlib-sync(Discord adapter) compiles with node-gyp, andnode:24-slimhas no Python or compiler.postinstallfails becausescripts/check-dep-uniqueness.mjsisn't copied into the builder.Change (
Dockerfile.agents)python3 make g++. The production stage copies the compilednode_modules, so the runtime image gets no toolchain.scripts/check-dep-uniqueness.mjs, so the single-version check runs in the image build too.Checked
python3is absent from the runtime image.mainfinishes and the container is healthy.Beads: foreman-tqq3
🤖 Generated with Claude Code